Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SUP-37490): Align captions with clipTo/SeekFrom Values in PlayManifest #876

Merged
merged 5 commits into from
Nov 11, 2024
Merged

fix(SUP-37490): Align captions with clipTo/SeekFrom Values in PlayManifest #876

merged 5 commits into from
Nov 11, 2024

Conversation

SivanA-Kaltura
Copy link
Contributor

@SivanA-Kaltura SivanA-Kaltura commented Nov 10, 2024 •
edited
Loading

Description of the Changes

If sources.seekFrom or sources.clipTo is set

  • Ignore the manifest text tracks, which will cause the playkit player to add external text tracks according to the getPlaybackContext captions metadata
  • Pass seekFrom and clipTo to the playkit player so that it will filter and shift the caption cues according to the new time range

Related PR: kaltura/playkit-js#798

@SivanA-Kaltura SivanA-Kaltura changed the title add clip captions fix(SUP-37490): Align captions with clipTo/SeekFrom Values in PlayManifest Nov 10, 2024
@SivanA-Kaltura SivanA-Kaltura mentioned this pull request Nov 10, 2024
Merged
5 tasks
@SivanA-Kaltura SivanA-Kaltura merged commit af28f65 into master Nov 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lianbenjamin lianbenjamin lianbenjamin approved these changes

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SivanA-Kaltura @semarche-kaltura @lianbenjamin